Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: remove eviction-related duplicate implementations #1393

Merged
merged 1 commit into from Jun 25, 2023

Conversation

leason00
Copy link
Contributor

Ⅰ. Describe what this PR does

unified access to EvictionGroupVersion

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: lisen <lisen@youzan.com>
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (f833fd9) 64.50% compared to head (d0b0d5f) 64.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
- Coverage   64.50%   64.48%   -0.03%     
==========================================
  Files         330      330              
  Lines       33905    33922      +17     
==========================================
+ Hits        21872    21876       +4     
- Misses      10427    10441      +14     
+ Partials     1606     1605       -1     
Flag Coverage Δ
unittests 64.48% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/controllers/migration/evictor/evictor_native.go 12.50% <0.00%> (ø)
pkg/descheduler/evictions/evictions.go 86.27% <0.00%> (ø)
pkg/util/pod_evict.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leason00 leason00 mentioned this pull request Jun 19, 2023
3 tasks
@hormes
Copy link
Member

hormes commented Jun 25, 2023

This PR fix #1374

@eahydra eahydra changed the title unified access to EvictionGroupVersion util: remove eviction-related duplicate implementations Jun 25, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1120b41 into koordinator-sh:main Jun 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants