Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: add noderesource plugin for Mid #1401

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

Add a noderesource plugin in slo-controller for Mid-tier allocatable calculation.

Proposed in #1385.

Ⅱ. Does this pull request fix one issue?

Part of #1361.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 80.31% and project coverage change: +0.08 🎉

Comparison is base (382f7a0) 64.74% compared to head (e85bee6) 64.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
+ Coverage   64.74%   64.82%   +0.08%     
==========================================
  Files         333      334       +1     
  Lines       34296    34421     +125     
==========================================
+ Hits        22204    22314     +110     
- Misses      10458    10468      +10     
- Partials     1634     1639       +5     
Flag Coverage Δ
unittests 64.82% <80.31%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/noderesource/plugins_profile.go 100.00% <ø> (ø)
...slo-controller/noderesource/resource_calculator.go 81.52% <66.66%> (-0.30%) ⬇️
...troller/noderesource/plugins/midresource/plugin.go 80.99% <80.99%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koord-manager-add-mid-colocation branch from ce344c1 to e85bee6 Compare June 21, 2023 03:02
@hormes
Copy link
Member

hormes commented Jun 25, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 34f79d3 into koordinator-sh:main Jun 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants