Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: refactor the implementation of Validate/Convert of request in DeviceShare #1413

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jun 25, 2023

Ⅰ. Describe what this PR does

In order to make it easier to expand and support new resource types, and to better express the supported resource combinations, the Validate and Convert implementations of Request in DeviceShare are refactored.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…equest in DeviceShare

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (34f79d3) 64.69% compared to head (d06ce75) 64.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   64.69%   64.59%   -0.10%     
==========================================
  Files         337      337              
  Lines       34533    34458      -75     
==========================================
- Hits        22341    22259      -82     
- Misses      10566    10574       +8     
+ Partials     1626     1625       -1     
Flag Coverage Δ
unittests 64.59% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/device_cache.go 88.59% <100.00%> (ø)
pkg/scheduler/plugins/deviceshare/plugin.go 62.12% <100.00%> (-2.69%) ⬇️
pkg/scheduler/plugins/deviceshare/utils.go 98.26% <100.00%> (-0.63%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4b581fb into koordinator-sh:main Jun 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants