Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-controller-manager: noderesource supports configuration plugins #1418

Merged
merged 1 commit into from Jun 26, 2023

Conversation

hormes
Copy link
Member

@hormes hormes commented Jun 26, 2023

Part of #1361

Support for user-configurable plugins that controllers need to enable

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 64.51% and project coverage change: -0.21 ⚠️

Comparison is base (056b1a4) 64.54% compared to head (f4066b4) 64.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   64.54%   64.34%   -0.21%     
==========================================
  Files         336      337       +1     
  Lines       34581    34588       +7     
==========================================
- Hits        22322    22255      -67     
- Misses      10629    10700      +71     
- Partials     1630     1633       +3     
Flag Coverage Δ
unittests 64.34% <64.51%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controller/noderesource/noderesource_controller.go 29.54% <0.00%> (-9.85%) ⬇️
cmd/koord-manager/options/options.go 82.50% <100.00%> (+1.94%) ⬆️
...ntroller/noderesource/framework/extender_plugin.go 46.80% <100.00%> (+3.62%) ⬆️
...troller/noderesource/plugins/midresource/plugin.go 80.99% <100.00%> (ø)
pkg/slo-controller/noderesource/plugins_profile.go 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member Author

hormes commented Jun 26, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 45a8257 into koordinator-sh:main Jun 26, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants