New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis: add default PriorityClass and QoSClass, revise batch resource calculation #1446
apis: add default PriorityClass and QoSClass, revise batch resource calculation #1446
Conversation
/hold for UTs |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 64.14% 64.09% -0.05%
==========================================
Files 341 341
Lines 34944 34939 -5
==========================================
- Hits 22415 22395 -20
- Misses 10879 10893 +14
- Partials 1650 1651 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
4e80149
to
1139636
Compare
1139636
to
2e106bc
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
2e106bc
to
6c42ce1
Compare
6c42ce1
to
3a9063a
Compare
…yclass and qosclass, fix noderesource plugin arg Signed-off-by: saintube <saintube@foxmail.com>
3a9063a
to
a88f244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…yclass and qosclass
Ⅰ. Describe what this PR does
noderesource-plugin
arg allows no plugin by default.Ⅱ. Does this pull request fix one issue?
Fixes #1441.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test