Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add default PriorityClass and QoSClass, revise batch resource calculation #1446

Conversation

saintube
Copy link
Member

@saintube saintube commented Jul 4, 2023

…yclass and qosclass

Ⅰ. Describe what this PR does

  • koord-manager: revise batch resource calculation, identifying the pods' priorityclasses.
  • koord-manager: fix a bug where the noderesource-plugin arg allows no plugin by default.
  • util: add default PriorityClass and QoSClass when any of them is missing.

Ⅱ. Does this pull request fix one issue?

Fixes #1441.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

saintube commented Jul 4, 2023

/hold for UTs

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 75.75% and project coverage change: -0.05 ⚠️

Comparison is base (b288455) 64.14% compared to head (a88f244) 64.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   64.14%   64.09%   -0.05%     
==========================================
  Files         341      341              
  Lines       34944    34939       -5     
==========================================
- Hits        22415    22395      -20     
- Misses      10879    10893      +14     
- Partials     1650     1651       +1     
Flag Coverage Δ
unittests 64.09% <75.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controller/noderesource/noderesource_controller.go 30.00% <0.00%> (ø)
pkg/util/pod_qos_utils.go 60.00% <ø> (ø)
...oller/noderesource/plugins/batchresource/plugin.go 69.61% <92.30%> (-0.17%) ⬇️
pkg/koordlet/resmanager/cgroup_reconcile.go 85.53% <100.00%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/util/slo_utils.go Outdated Show resolved Hide resolved
pkg/util/slo_utils.go Outdated Show resolved Hide resolved
@saintube saintube force-pushed the koord-manager-revise-batch-resource-calculation branch from 4e80149 to 1139636 Compare July 5, 2023 03:34
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Jul 5, 2023
@saintube saintube force-pushed the koord-manager-revise-batch-resource-calculation branch from 1139636 to 2e106bc Compare July 5, 2023 11:42
@saintube
Copy link
Member Author

saintube commented Jul 5, 2023

/unhold

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube force-pushed the koord-manager-revise-batch-resource-calculation branch from 2e106bc to 6c42ce1 Compare July 6, 2023 09:42
@koordinator-bot koordinator-bot bot removed the lgtm label Jul 6, 2023
@saintube saintube force-pushed the koord-manager-revise-batch-resource-calculation branch from 6c42ce1 to 3a9063a Compare July 6, 2023 12:46
apis/extension/priority.go Outdated Show resolved Hide resolved
…yclass and qosclass, fix noderesource plugin arg

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koord-manager-revise-batch-resource-calculation branch from 3a9063a to a88f244 Compare July 7, 2023 04:00
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 7, 2023
@saintube saintube changed the title koord-manager: revise batch resource calculation, add default priorit… apis: add default PriorityClass and QoSClass, revise batch resource calculation Jul 7, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 06b2f5b into koordinator-sh:main Jul 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Revise batch resource calculation
4 participants