Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: add README for noderesource framework #1496

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

koord-manager: Add a README for the node resource framework.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (9232daf) 64.07% compared to head (2de758b) 64.04%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   64.07%   64.04%   -0.03%     
==========================================
  Files         340      340              
  Lines       35057    35057              
==========================================
- Hits        22463    22454       -9     
- Misses      10931    10938       +7     
- Partials     1663     1665       +2     
Flag Coverage Δ
unittests 64.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the koord-manager-add-noderesource-stage-readme branch from f6a79e1 to 84c5357 Compare July 26, 2023 03:22
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koord-manager-add-noderesource-stage-readme branch from 84c5357 to 2de758b Compare July 27, 2023 12:17
@hormes
Copy link
Member

hormes commented Jul 28, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 091cd40 into koordinator-sh:main Jul 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants