Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix flaky tests #1498

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

koordlet: Fix flaky tests in be_resource_collector_test.go. Fix flag parsing UTs which cannot run with go test -race.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (9232daf) 64.07% compared to head (6142886) 64.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
- Coverage   64.07%   64.04%   -0.03%     
==========================================
  Files         340      340              
  Lines       35057    35056       -1     
==========================================
- Hits        22463    22452      -11     
- Misses      10931    10942      +11     
+ Partials     1663     1662       -1     
Flag Coverage Δ
unittests 64.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...statesinformer/impl/states_noderesourcetopology.go 66.10% <ø> (-0.08%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-fix-flaky-test-in-beresourcecollector branch from 21d6a70 to 6142886 Compare July 27, 2023 04:27
@koordinator-bot koordinator-bot bot requested review from eahydra and hormes July 27, 2023 06:28
@hormes
Copy link
Member

hormes commented Jul 28, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 30b47b2 into koordinator-sh:main Jul 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants