New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add nri server for runtimehooks #1501
Conversation
83a3535
to
ae53333
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 64.04% 64.85% +0.81%
==========================================
Files 340 349 +9
Lines 35056 35802 +746
==========================================
+ Hits 22452 23220 +768
+ Misses 10938 10864 -74
- Partials 1666 1718 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@saintube: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome to participate in Koordinator's technical co-construction, and jointly promote the evolution of the framework of community standards(nri). |
173aed8
to
c0289fa
Compare
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kangclzjc Thanks for your contributions!
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
Signed-off-by: Kang.Zhang <kang.zhang@intel.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Koordinator as a QoS based scheduling system for hybrid workloads orchestration on Kubernetes and its runtime hooks support two working modes for different scenarios: Standalone and Proxy. However, both of them have some constraints in 2023/02/07 meeting discussion. We'd like to integrate NRI framework to address these constraints based on community recommend mechanism.
This PR will implement a NRI plugin in koordlet. Currently, it co-exist with standalone and proxy mode. Koodlet will start an NRI plugin to subscribe pod/container lifecycle events from container runtime (e.g. containerd, crio), and then koordlet NRI plugin will call runtime hooks to adjust pod resources or OCI spec.
Ⅱ. Does this pull request fix one issue?
fix #1277
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test