Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add HostApplications for out-of-band application #1508

Merged
merged 1 commit into from
Sep 2, 2023
Merged

apis: add HostApplications for out-of-band application #1508

merged 1 commit into from
Sep 2, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jul 28, 2023

Ⅰ. Describe what this PR does

Define APIs and configurations to identify processes for these out-of-band applications

Ⅱ. Does this pull request fix one issue?

#1639

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes July 28, 2023 10:02
@zwzhang0107
Copy link
Contributor Author

/hold

@zwzhang0107
Copy link
Contributor Author

/hold cancel

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.51% ⚠️

Comparison is base (11f1bbb) 65.15% compared to head (d0d2379) 64.65%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   65.15%   64.65%   -0.51%     
==========================================
  Files         352      360       +8     
  Lines       36326    37248     +922     
==========================================
+ Hits        23669    24081     +412     
- Misses      10913    11400     +487     
- Partials     1744     1767      +23     
Flag Coverage Δ
unittests 64.65% <100.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/features/koordlet_features.go 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 914a4a2 into koordinator-sh:main Sep 2, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants