New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support numa topology reporting #1516
koordlet: support numa topology reporting #1516
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
==========================================
+ Coverage 64.62% 64.78% +0.15%
==========================================
Files 346 347 +1
Lines 35123 35355 +232
==========================================
+ Hits 22699 22905 +206
- Misses 10756 10768 +12
- Partials 1668 1682 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
d9a41b7
to
7a9dcb4
Compare
if err != nil { | ||
return 0, err | ||
} | ||
usage := int64(memInfo.MemTotal - memInfo.MemAvailable) | ||
return usage, nil | ||
} | ||
|
||
type NUMAInfo struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is socket id can be identified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid not. There is no info about the socket and core relations under the numa info directory. If we want to look up the socket ID of the NUMA node, we need to check the cpu info instead.
Signed-off-by: saintube <saintube@foxmail.com>
7a9dcb4
to
66c0920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Fixes #1503.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test