Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix the cpu.shares conversion on cgroups-v2 #1521

Conversation

saintube
Copy link
Member

@saintube saintube commented Aug 2, 2023

Ⅰ. Describe what this PR does

koordlet: fix the value conversion between cpu.shares and cpu.weights (cgroups-v2), use the same conversion as the kubelet.

link: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2254-cgroup-v2#phase-1-convert-from-cgroups-v1-settings-to-v2

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@hormes
Copy link
Member

hormes commented Aug 3, 2023

/lgtm
/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.02% 🎉

Comparison is base (53efaaf) 64.62% compared to head (976c51d) 64.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
+ Coverage   64.62%   64.65%   +0.02%     
==========================================
  Files         346      346              
  Lines       35123    35129       +6     
==========================================
+ Hits        22699    22712      +13     
+ Misses      10756    10754       -2     
+ Partials     1668     1663       -5     
Flag Coverage Δ
unittests 64.65% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/koordlet/util/system/cgroup_resource.go 83.50% <ø> (ø)
pkg/koordlet/util/system/cgroup2.go 84.08% <75.00%> (-0.44%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit 37611ab into koordinator-sh:main Aug 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants