Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add gang match policy alias annotation #1530

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 4, 2023

Ⅰ. Describe what this PR does

  1. Move the Gang scheduling extension APIs to file apis/extension/coscheduling.go.
  2. Add gang match policy alias pod-group.scheduling.sigs.k8s.io/match-policy to compatible with special scenarios.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (2a23dd6) 64.80% compared to head (d0cd643) 64.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   64.80%   64.77%   -0.04%     
==========================================
  Files         347      347              
  Lines       35365    35365              
==========================================
- Hits        22920    22908      -12     
- Misses      10763    10774      +11     
- Partials     1682     1683       +1     
Flag Coverage Δ
unittests 64.77% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the compatible_ack_gang_match_policy branch from c8180cc to d0cd643 Compare August 8, 2023 05:45
@eahydra eahydra requested a review from hormes August 8, 2023 05:46
@eahydra eahydra changed the title apis: compatible ACK gang match policy apis: add gang match policy alias annotation Aug 8, 2023
@hormes
Copy link
Member

hormes commented Aug 8, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f51c48e into koordinator-sh:main Aug 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants