Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: fix node slo extension got overwriten #1552

Merged
merged 1 commit into from
Aug 16, 2023
Merged

koord-manager: fix node slo extension got overwriten #1552

merged 1 commit into from
Aug 16, 2023

Conversation

zwzhang0107
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.03% ⚠️

Comparison is base (5c4340f) 65.02% compared to head (3112044) 64.99%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   65.02%   64.99%   -0.03%     
==========================================
  Files         352      352              
  Lines       36198    36200       +2     
==========================================
- Hits        23536    23528       -8     
- Misses      10924    10931       +7     
- Partials     1738     1741       +3     
Flag Coverage Δ
unittests 64.99% <81.81%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/slo-controller/nodeslo/extender_plugin.go 78.72% <80.00%> (-1.28%) ⬇️
pkg/slo-controller/nodeslo/nodeslo_controller.go 47.71% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b791330 into koordinator-sh:main Aug 16, 2023
16 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…1552)

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants