koord-manager: allow quotas that are not bound to pods to become parent nodes #1553

xulinfei1996 · 2023-08-16T09:27:19Z

Ⅰ. Describe what this PR does

Relax the limit of IsParent change.
If quota is not bound to pods, it can become parent node.
If quota doesn't have children, it can become child node.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

I have written necessary docs and comments
I have added necessary unit tests and integration tests
All checks passed in make test

codecov · 2023-08-16T09:33:32Z

Codecov Report

Patch coverage: 60.97% and project coverage change: +0.01% 🎉

Comparison is base (b791330) 65.04% compared to head (9a48536) 65.05%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   65.04%   65.05%   +0.01%     
==========================================
  Files         352      352              
  Lines       36214    36288      +74     
==========================================
+ Hits        23556    23608      +52     
- Misses      10919    10938      +19     
- Partials     1739     1742       +3

Flag	Coverage Δ
unittests	`65.05% <60.97%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/webhook/elasticquota/pod_check.go	`71.69% <36.84%> (-19.48%)`	⬇️
pkg/webhook/elasticquota/quota_topology.go	`67.20% <50.00%> (ø)`
pkg/webhook/elasticquota/quota_topology_check.go	`75.70% <85.00%> (+2.41%)`	⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apis/extension/elastic_quota.go

pkg/webhook/elasticquota/quota_topology_check.go

pkg/util/fieldindex/register.go

pkg/webhook/elasticquota/quota_topology_check.go

pkg/webhook/elasticquota/pod_check.go

eahydra · 2023-08-17T07:55:51Z

/lgtm

pkg/webhook/elasticquota/quota_topology_check.go

buptcozy

/approve

…nt nodes Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>

eahydra

/lgtm

buptcozy

/approve

shaloulcy · 2023-08-21T12:14:01Z

/lgtm

koordinator-bot · 2023-08-21T12:14:10Z

@shaloulcy: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hormes · 2023-08-22T02:29:04Z

/approve

koordinator-bot · 2023-08-22T02:29:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hormes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…nt nodes (koordinator-sh#1553) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>

koordinator-bot bot requested review from eahydra and FillZpp August 16, 2023 09:27

koordinator-bot bot added the size/M label Aug 16, 2023

eahydra reviewed Aug 17, 2023

View reviewed changes

apis/extension/elastic_quota.go Outdated Show resolved Hide resolved

pkg/webhook/elasticquota/quota_topology_check.go Outdated Show resolved Hide resolved

xulinfei1996 force-pushed the quota-is-parent branch from 055fcf3 to b20bf7f Compare August 17, 2023 05:37

koordinator-bot bot added size/L and removed size/M labels Aug 17, 2023

xulinfei1996 changed the title ~~koord-scheduler: refine quota webhook check quota topology~~ koord-manager: refine quota webhook check quota topology Aug 17, 2023

xulinfei1996 force-pushed the quota-is-parent branch from b20bf7f to 94cf5b1 Compare August 17, 2023 05:41

eahydra reviewed Aug 17, 2023

View reviewed changes

pkg/util/fieldindex/register.go Outdated Show resolved Hide resolved

pkg/webhook/elasticquota/quota_topology_check.go Show resolved Hide resolved

pkg/webhook/elasticquota/pod_check.go Show resolved Hide resolved

eahydra changed the title ~~koord-manager: refine quota webhook check quota topology~~ koord-manager: allow quotas that are not bound to Pods to become parent nodes Aug 17, 2023

xulinfei1996 force-pushed the quota-is-parent branch from 94cf5b1 to bf2a7d5 Compare August 17, 2023 07:52

koordinator-bot bot assigned eahydra Aug 17, 2023

koordinator-bot bot added the lgtm label Aug 17, 2023

eahydra changed the title ~~koord-manager: allow quotas that are not bound to Pods to become parent nodes~~ koord-manager: allow quotas that are not bound to pods to become parent nodes Aug 17, 2023

buptcozy reviewed Aug 17, 2023

View reviewed changes

pkg/webhook/elasticquota/quota_topology_check.go Outdated Show resolved Hide resolved

xulinfei1996 force-pushed the quota-is-parent branch from bf2a7d5 to add7eaa Compare August 17, 2023 08:09

koordinator-bot bot removed the lgtm label Aug 17, 2023

buptcozy approved these changes Aug 17, 2023

View reviewed changes

xulinfei1996 force-pushed the quota-is-parent branch from add7eaa to 615d6dd Compare August 17, 2023 08:22

koord-manager: allow quotas that are not bound to pods to become pare…

9a48536

…nt nodes Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>

xulinfei1996 force-pushed the quota-is-parent branch from 615d6dd to 9a48536 Compare August 18, 2023 08:05

eahydra reviewed Aug 21, 2023

View reviewed changes

koordinator-bot bot added the lgtm label Aug 21, 2023

buptcozy approved these changes Aug 21, 2023

View reviewed changes

koordinator-bot bot added the approved label Aug 22, 2023

koordinator-bot bot merged commit 5172d5d into koordinator-sh:main Aug 22, 2023
16 checks passed

This was referenced Feb 26, 2024

REQUEST: New membership for < xulinfei1996 > #1924

Closed

[REQUEST Membership]: New membership for <xulinfei1996> koordinator-sh/community#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

koord-manager: allow quotas that are not bound to pods to become parent nodes #1553

koord-manager: allow quotas that are not bound to pods to become parent nodes #1553

xulinfei1996 commented Aug 16, 2023 •

edited

codecov bot commented Aug 16, 2023 •

edited

eahydra commented Aug 17, 2023

buptcozy left a comment

eahydra left a comment

buptcozy left a comment

shaloulcy commented Aug 21, 2023

koordinator-bot bot commented Aug 21, 2023

hormes commented Aug 22, 2023

koordinator-bot bot commented Aug 22, 2023

koord-manager: allow quotas that are not bound to pods to become parent nodes #1553

koord-manager: allow quotas that are not bound to pods to become parent nodes #1553

Conversation

xulinfei1996 commented Aug 16, 2023 • edited

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

codecov bot commented Aug 16, 2023 • edited

Codecov Report

eahydra commented Aug 17, 2023

buptcozy left a comment

Choose a reason for hiding this comment

eahydra left a comment

Choose a reason for hiding this comment

buptcozy left a comment

Choose a reason for hiding this comment

shaloulcy commented Aug 21, 2023

koordinator-bot bot commented Aug 21, 2023

hormes commented Aug 22, 2023

koordinator-bot bot commented Aug 22, 2023

xulinfei1996 commented Aug 16, 2023 •

edited

codecov bot commented Aug 16, 2023 •

edited