-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: improve batch resource calculation with system metrics #1559
koord-manager: improve batch resource calculation with system metrics #1559
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 65.16% 65.18% +0.01%
==========================================
Files 352 352
Lines 36326 36320 -6
==========================================
+ Hits 23673 23676 +3
+ Misses 10907 10901 -6
+ Partials 1746 1743 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/lgtm |
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
Signed-off-by: saintube <saintube@foxmail.com>
3e43455
to
d1b4856
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…koordinator-sh#1559) Signed-off-by: saintube <saintube@foxmail.com>
podHPUsed = quotav1.Add(podHPUsed, getPodMetricUsage(podMetric)) | ||
} else { | ||
podHPUsed = quotav1.Add(podHPUsed, podRequest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use Request if has no metric, how about skip?
…koordinator-sh#1559) Signed-off-by: saintube <saintube@foxmail.com>
…koordinator-sh#1559) Signed-off-by: saintube <saintube@foxmail.com>
Ⅰ. Describe what this PR does
koord-manager: Improve the calculation of the batch resource allocatable with the newly-added system metrics.
Ⅱ. Does this pull request fix one issue?
Fixes #1427.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
Please note that the calculated allocatable can be lower than the real result at the nodeMetric reported time. It becomes accurate when there are no more pods terminated or newly-scheduled between the nodeMetric reported time and the controller calculating time.
V. Checklist
make test