Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: only enable necessary plugin in the ut of resource calculator #1564

Merged
merged 1 commit into from
Aug 22, 2023
Merged

koord-manager: only enable necessary plugin in the ut of resource calculator #1564

merged 1 commit into from
Aug 22, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Aug 21, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 changed the title -manager: only enable necessary plugin in the ut of resource calculator koord-manager: only enable necessary plugin in the ut of resource calculator Aug 21, 2023
…culator

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@koordinator-bot koordinator-bot bot added size/XS and removed size/L labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8499a6) 65.04% compared to head (88eda4e) 65.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1564   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         352      352           
  Lines       36273    36273           
=======================================
+ Hits        23592    23595    +3     
+ Misses      10937    10936    -1     
+ Partials     1744     1742    -2     
Flag Coverage Δ
unittests 65.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2c3ad76 into koordinator-sh:main Aug 22, 2023
16 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…culator (koordinator-sh#1564)

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…culator (koordinator-sh#1564)

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants