Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koord-scheduler: add annotation about namespaces that limit quota usage #1566

Merged
merged 1 commit into from
Sep 8, 2023
Merged

koord-scheduler: add annotation about namespaces that limit quota usage #1566

merged 1 commit into from
Sep 8, 2023

Conversation

xulinfei1996
Copy link
Contributor

Ⅰ. Describe what this PR does

Add an annotation to expand the bound relationship of ElasticQuota and Pod.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@xulinfei1996 xulinfei1996 force-pushed the quota-support-namespace branch 2 times, most recently from 35726de to 5c50e24 Compare August 22, 2023 05:50
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 63.09% and project coverage change: -0.03% ⚠️

Comparison is base (52f57b6) 65.29% compared to head (b045fc5) 65.26%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
- Coverage   65.29%   65.26%   -0.03%     
==========================================
  Files         369      369              
  Lines       38117    38188      +71     
==========================================
+ Hits        24889    24924      +35     
- Misses      11404    11434      +30     
- Partials     1824     1830       +6
Flag Coverage Δ
unittests 65.26% <63.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/webhook/elasticquota/pod_check.go 56.94% <27.27%> (-14.76%) ⬇️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 83.01% <58.33%> (-2.32%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 63.18% <62.50%> (-0.51%) ⬇️
pkg/webhook/elasticquota/quota_topology.go 72.18% <87.09%> (+4.98%) ⬆️
pkg/webhook/elasticquota/quota_topology_check.go 74.86% <100.00%> (+0.41%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@xulinfei1996 xulinfei1996 force-pushed the quota-support-namespace branch 3 times, most recently from 6c8d169 to 48521fb Compare August 23, 2023 02:46
eahydra
eahydra reviewed Aug 25, 2023
View reviewed changes
apis/extension/elastic_quota.go Outdated Show resolved Hide resolved
docs/proposals/scheduling/20220722-multi-hierarchy-elastic-quota-management.md Outdated Show resolved Hide resolved
pkg/scheduler/plugins/elasticquota/plugin_helper.go Outdated Show resolved Hide resolved
pkg/webhook/elasticquota/pod_check.go Outdated Show resolved Hide resolved
@xulinfei1996 xulinfei1996 force-pushed the quota-support-namespace branch 6 times, most recently from c64f219 to 762af44 Compare September 1, 2023 02:07
@hormes
Copy link
Member

hormes commented Sep 2, 2023

@xulinfei1996 Please add some use cases, why should they be limited to a list of namespaces?

eahydra
eahydra reviewed Sep 3, 2023
View reviewed changes
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Sep 3, 2023
@eahydra
Copy link
Member

eahydra commented Sep 3, 2023

Please add some use cases, why should they be limited to a list of namespaces

@hormes Koordinator ElasticQuota can support all namspaces by default. On this basis, a namespace list is added to limit, which can be compatible with internal scenarios, such as ACK ElasticQuotaTree.

@eahydra
Copy link
Member

eahydra commented Sep 3, 2023

@xulinfei1996 Hi, there are some conflicts in the files, please fix them.

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 4, 2023
@xulinfei1996 xulinfei1996 force-pushed the quota-support-namespace branch 2 times, most recently from 0a5332d to e30227c Compare September 6, 2023 12:18
koord-scheduler: add annotation about namespaces that limit quota usage
b045fc5 
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@eahydra
Copy link
Member

eahydra commented Sep 8, 2023

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Sep 8, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b4ee934 into koordinator-sh:main Sep 8, 2023
19 checks passed
This was referenced Feb 26, 2024
Closed
Closed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
@xulinfei1996
koord-scheduler: add annotation about namespaces that limit quota usa…
03a6eb6 
…ge (koordinator-sh#1566)

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
@xulinfei1996 @ls-2018
koord-scheduler: add annotation about namespaces that limit quota usa…
45192b9 
…ge (koordinator-sh#1566)

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eahydra eahydra eahydra left review comments

@hormes hormes hormes approved these changes

@buptcozy buptcozy Awaiting requested review from buptcozy

@FillZpp FillZpp Awaiting requested review from FillZpp

@yihuifeng yihuifeng Awaiting requested review from yihuifeng

Assignees

@eahydra eahydra

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xulinfei1996 @hormes @eahydra