Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook patch manifests for pod update mutation #1575

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Aug 24, 2023

Ⅰ. Describe what this PR does

Fix webhook patch manifests for pod update mutation

Ⅱ. Does this pull request fix one issue?

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (bb9907d) 65.16% compared to head (049f591) 65.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
- Coverage   65.16%   65.16%   -0.01%     
==========================================
  Files         352      352              
  Lines       36326    36326              
==========================================
- Hits        23673    23671       -2     
- Misses      10907    10915       +8     
+ Partials     1746     1740       -6     
Flag Coverage Δ
unittests 65.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 739d06d into koordinator-sh:main Aug 24, 2023
15 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
)

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
)

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants