koord-scheduler: fix missing IsParent when rebuild tree #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parent quotas has isParent labels Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
+ Coverage 65.04% 65.18% +0.14%
==========================================
Files 352 352
Lines 36273 36327 +54
==========================================
+ Hits 23592 23680 +88
+ Misses 10937 10904 -33
+ Partials 1744 1743 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
changed the title
eahydra
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
koordinator-bot
bot
merged commit 6f817dd
into
koordinator-sh:main
14 of 15 checks passed
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…sh#1576) Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com> Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…sh#1576) Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com> Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Fix IsParent in the quota tree rebuild
some parent quotas has no is-parent label. we should fix it in the rebuild phase
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test