-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: revise nri server start #1578
koordlet: revise nri server start #1578
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage ? 65.18%
=======================================
Files ? 352
Lines ? 36353
Branches ? 0
=======================================
Hits ? 23698
Misses ? 10911
Partials ? 1744
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/cc @kangclzjc |
@saintube: GitHub didn't allow me to request PR reviews from the following users: kangclzjc. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: saintube <saintube@foxmail.com>
a713bdc
to
d8ccb81
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Ⅰ. Describe what this PR does
koordlet: revise nri server starting, check if nri.sock exists before new the server.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test