Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: revise nri server start #1578

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

koordlet: revise nri server starting, check if nri.sock exists before new the server.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@04c5ba8). Click here to learn what that means.
Patch coverage: 83.87% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1578   +/-   ##
=======================================
  Coverage        ?   65.18%           
=======================================
  Files           ?      352           
  Lines           ?    36353           
  Branches        ?        0           
=======================================
  Hits            ?    23698           
  Misses          ?    10911           
  Partials        ?     1744           
Flag Coverage Δ
unittests 65.18% <83.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/koordlet/runtimehooks/runtimehooks.go 70.47% <80.00%> (ø)
pkg/koordlet/runtimehooks/nri/server.go 61.06% <84.00%> (ø)
pkg/koordlet/util/system/util_test_tool.go 51.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member Author

/cc @kangclzjc

@koordinator-bot
Copy link

@saintube: GitHub didn't allow me to request PR reviews from the following users: kangclzjc.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kangclzjc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-revise-nri-server-start branch from a713bdc to d8ccb81 Compare August 26, 2023 04:00
@hormes
Copy link
Member

hormes commented Aug 26, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8ed0f75 into koordinator-sh:main Aug 26, 2023
16 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants