Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support NUMA-aware scheduling #1592

Merged
merged 1 commit into from Aug 30, 2023

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 29, 2023

Ⅰ. Describe what this PR does

  • Plugin NodeNUMAResource supports scheduling Pods based on NUMA node topology and policies defined on Node or NRT.
  • Currently the plugin supports all strategies including BestEffort, Restricted and SingleNUMANode.
  • And it is also compatible with the original CPUSet scheduling logic
  • But it does not support Pod allocation and preemption from Reservation and Node based on NUMA Node Topology, which I will implement later.
  • And it does not support scoring based on the NUMA node topology. I haven't figured out how to implement a new scoring algorithm to be compatible with the original CPUSet scenario, or I can consider scoring only according to the resources of the NUMA Node.

All E2E cases have passed.

Ⅱ. Does this pull request fix one issue?

part of #228

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 49.11% and project coverage change: -0.50% ⚠️

Comparison is base (8a73b0e) 65.25% compared to head (bf95700) 64.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1592      +/-   ##
==========================================
- Coverage   65.25%   64.75%   -0.50%     
==========================================
  Files         359      360       +1     
  Lines       36719    37183     +464     
==========================================
+ Hits        23960    24077     +117     
- Misses      11011    11341     +330     
- Partials     1748     1765      +17     
Flag Coverage Δ
unittests 64.75% <49.11%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...scheduler/plugins/nodenumaresource/cpu_topology.go 53.47% <ø> (-0.33%) ⬇️
...cheduler/plugins/nodenumaresource/topology_hint.go 0.00% <0.00%> (ø)
...duler/plugins/nodenumaresource/resource_manager.go 37.72% <37.72%> (ø)
...duler/plugins/nodenumaresource/topology_options.go 51.85% <51.85%> (ø)
...heduler/plugins/nodenumaresource/plugin_service.go 53.84% <57.77%> (-23.94%) ⬇️
pkg/scheduler/plugins/nodenumaresource/plugin.go 65.64% <65.06%> (+2.03%) ⬆️
...eduler/plugins/nodenumaresource/node_allocation.go 70.21% <70.21%> (ø)
...duler/plugins/nodenumaresource/pod_eventhandler.go 60.22% <70.83%> (-3.07%) ⬇️
...eduler/plugins/nodenumaresource/cpu_accumulator.go 83.21% <77.50%> (+0.43%) ⬆️
.../plugins/nodenumaresource/topology_eventhandler.go 53.22% <93.33%> (-0.63%) ⬇️
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 656e7e2 into koordinator-sh:main Aug 30, 2023
19 checks passed
@eahydra eahydra added this to the v1.4 milestone Sep 3, 2023
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants