Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add elastic quota profile #1596

Merged
merged 1 commit into from Aug 31, 2023

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add elastic quota profile

Every quota profile will generate a root quota tree

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra changed the title add elastic quota profile apis: add elastic quota profile Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.61% ⚠️

Comparison is base (490dfd6) 65.28% compared to head (cde9b35) 64.68%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   65.28%   64.68%   -0.61%     
==========================================
  Files         359      360       +1     
  Lines       36718    37248     +530     
==========================================
+ Hits        23971    24093     +122     
- Misses      10995    11388     +393     
- Partials     1752     1767      +15     
Flag Coverage Δ
unittests 64.68% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Aug 31, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f3a5db8 into koordinator-sh:main Aug 31, 2023
19 checks passed
@shaloulcy shaloulcy mentioned this pull request Sep 2, 2023
8 tasks
@hormes
Copy link
Member

hormes commented Sep 9, 2023

#1606

ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants