Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: supports plugins to adjust reservation reusable resources #1600

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 1, 2023

Ⅰ. Describe what this PR does

Plugins like DeviceShare will add additional normalized resources after the scheduling is successful, and there may be more resources than Pod expects to apply for. In the Reservation scenario, these need to be backfilled to the Reservation and be perceived by subsequent links, so as to complete similar scenarios. resource reuse. This PR is to solve this problem.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 41.39% and project coverage change: -0.03% ⚠️

Comparison is base (c5b245a) 64.70% compared to head (c313a96) 64.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
- Coverage   64.70%   64.67%   -0.03%     
==========================================
  Files         360      360              
  Lines       37281    37459     +178     
==========================================
+ Hits        24122    24227     +105     
- Misses      11395    11456      +61     
- Partials     1764     1776      +12     
Flag Coverage Δ
unittests 64.67% <41.39%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/features/scheduler_features.go 100.00% <ø> (ø)
pkg/scheduler/frameworkext/framework_extender.go 57.29% <0.00%> (-5.11%) ⬇️
...heduler/frameworkext/framework_extender_factory.go 51.37% <0.00%> (-26.41%) ⬇️
pkg/scheduler/frameworkext/interface.go 0.00% <ø> (ø)
pkg/scheduler/plugins/reservation/plugin.go 76.02% <0.00%> (-0.58%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 57.03% <27.90%> (-3.79%) ⬇️
pkg/util/reservation/reservation.go 58.75% <81.25%> (+19.82%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra
Copy link
Member Author

eahydra commented Sep 1, 2023

/hold

@eahydra
Copy link
Member Author

eahydra commented Sep 2, 2023

/hold cancel
PTAl @hormes @FillZpp @jasonliu747 @saintube @ZiMengSheng

…urces

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the resize_reservation_allocatable branch from 293bdb6 to c313a96 Compare September 2, 2023 04:00
@hormes
Copy link
Member

hormes commented Sep 2, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 88b57e5 into koordinator-sh:main Sep 2, 2023
18 of 19 checks passed
@eahydra eahydra added this to the v1.4 milestone Sep 3, 2023
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…urces (koordinator-sh#1600)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants