Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi quota tree #1603

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add quota manager for profile

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 62.50% and no project coverage change.

Comparison is base (88b57e5) 64.71% compared to head (33de2f0) 64.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1603    +/-   ##
========================================
  Coverage   64.71%   64.71%            
========================================
  Files         360      361     +1     
  Lines       37513    37636   +123     
========================================
+ Hits        24277    24357    +80     
- Misses      11458    11490    +32     
- Partials     1778     1789    +11     
Flag Coverage Δ
unittests 64.71% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/features/features.go 60.00% <ø> (ø)
pkg/features/scheduler_features.go 100.00% <ø> (ø)
pkg/scheduler/plugins/elasticquota/node_handler.go 50.00% <ø> (-3.13%) ⬇️
.../scheduler/plugins/elasticquota/profile_handler.go 55.55% <55.55%> (ø)
...r/plugins/elasticquota/core/group_quota_manager.go 72.96% <59.15%> (-1.18%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 63.69% <88.46%> (+5.69%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Sep 2, 2023

/lgtm

chuanyun.lcy added 4 commits September 2, 2023 17:24
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Sep 2, 2023

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Sep 2, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 199e650 into koordinator-sh:main Sep 2, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants