Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: report CPUBasicInfo, adjust normalized cpu cgroups #1604

Conversation

saintube
Copy link
Member

@saintube saintube commented Sep 2, 2023

Ⅰ. Describe what this PR does

koordlet: support CPU Normalization.

  1. Report CPUBasicInfo onto NRT annotations.
  2. Adjust cgroups cpu.cfs_quota_us for LS and BE (cpushare) pods according to the normalized ratio.
  3. Fix a flaky test in pod_resource_collector.go.

Ⅱ. Does this pull request fix one issue?

Part of #1570.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the koordlet-support-cpu-normalization branch from 1afca75 to 5e3abdb Compare September 5, 2023 13:34
@koordinator-bot koordinator-bot bot added size/XXL and removed size/L labels Sep 5, 2023
@saintube saintube changed the title [WIP] koordlet: report CPUBasicInfo, adjust normalized cpu cgroups koordlet: report CPUBasicInfo, adjust normalized cpu cgroups Sep 5, 2023
@saintube
Copy link
Member Author

saintube commented Sep 5, 2023

/hold for UT

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 71.98% and project coverage change: +0.19% 🎉

Comparison is base (52f57b6) 65.29% compared to head (88a7d32) 65.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   65.29%   65.49%   +0.19%     
==========================================
  Files         369      371       +2     
  Lines       38117    38583     +466     
==========================================
+ Hits        24889    25269     +380     
- Misses      11404    11483      +79     
- Partials     1824     1831       +7     
Flag Coverage Δ
unittests 65.49% <71.98%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/koordlet/resourceexecutor/executor.go 41.42% <0.00%> (-1.27%) ⬇️
pkg/koordlet/runtimehooks/config.go 100.00% <ø> (ø)
.../koordlet/runtimehooks/protocol/kubeqos_context.go 0.00% <0.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 59.16% <0.00%> (ø)
pkg/koordlet/util/container.go 68.88% <0.00%> (+5.62%) ⬆️
pkg/koordlet/util/system/cgroup.go 77.77% <0.00%> (-12.55%) ⬇️
pkg/koordlet/util/system/cgroup_resource.go 83.50% <ø> (ø)
pkg/koordlet/util/system/resctrl_linux.go 77.17% <ø> (ø)
pkg/koordlet/runtimehooks/protocol/pod_context.go 22.83% <20.00%> (-2.52%) ⬇️
pkg/koordlet/util/system/system_file.go 60.52% <33.33%> (-2.34%) ⬇️
... and 14 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the koordlet-support-cpu-normalization branch 4 times, most recently from 2c59b09 to 61703de Compare September 6, 2023 11:00
@saintube
Copy link
Member Author

saintube commented Sep 6, 2023

/unhold
/cc @zwzhang0107 @zqzten @eahydra @hormes @jasonliu747

@koordinator-bot
Copy link

@saintube: GitHub didn't allow me to request PR reviews from the following users: zqzten.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/unhold
/cc @zwzhang0107 @zqzten @eahydra @hormes @jasonliu747

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saintube saintube force-pushed the koordlet-support-cpu-normalization branch 5 times, most recently from 30a8a66 to 797e940 Compare September 7, 2023 03:38
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-support-cpu-normalization branch from 797e940 to 88a7d32 Compare September 7, 2023 08:34
@hormes
Copy link
Member

hormes commented Sep 8, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b31ec5c into koordinator-sh:main Sep 8, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants