Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: add quota profile controller #1605

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add quota profile controller. It will update the quota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 60.97% and project coverage change: +0.02% 🎉

Comparison is base (d464735) 65.01% compared to head (4a80ad1) 65.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
+ Coverage   65.01%   65.04%   +0.02%     
==========================================
  Files         363      364       +1     
  Lines       37767    37890     +123     
==========================================
+ Hits        24555    24644      +89     
- Misses      11403    11431      +28     
- Partials     1809     1815       +6     
Flag Coverage Δ
unittests 65.04% <60.97%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/quota-controller/profile/profile_controller.go 60.33% <60.33%> (ø)
cmd/koord-manager/options/scheme.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaloulcy shaloulcy force-pushed the add_profile_controller branch 2 times, most recently from 11b0585 to 5795f4e Compare September 2, 2023 08:29
@eahydra eahydra changed the title add quota profile controller koord-manager: add quota profile controller Sep 2, 2023
@shaloulcy shaloulcy mentioned this pull request Sep 2, 2023
8 tasks
@shaloulcy shaloulcy force-pushed the add_profile_controller branch 2 times, most recently from 450cd47 to a1c76ff Compare September 4, 2023 02:32
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Sep 4, 2023
@shaloulcy shaloulcy force-pushed the add_profile_controller branch 2 times, most recently from 8ff2b9d to c0722d4 Compare September 4, 2023 03:13
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Sep 6, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c46de75 into koordinator-sh:main Sep 6, 2023
19 checks passed
@shaloulcy
Copy link
Contributor Author

#1606

ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants