Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: report be cpu share pool and set cpuset if specified #1626

Merged
merged 1 commit into from Sep 11, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Sep 7, 2023

Ⅰ. Describe what this PR does

Report be cpu share pool in annotation of NodeResourceTopo
Set cpuset according to specified numa node id for BE pod is scheduler specified.

BECPUSuppress should not work together with BECPUManager.
If both enabled, CPUSuppress will recover cpuset on all level for be pod does not specified numa node, and let be cpu set hook handle the others

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 70.41% and project coverage change: +0.29% 🎉

Comparison is base (b31ec5c) 65.46% compared to head (9de0412) 65.76%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
+ Coverage   65.46%   65.76%   +0.29%     
==========================================
  Files         371      373       +2     
  Lines       38654    39378     +724     
==========================================
+ Hits        25306    25896     +590     
- Misses      11509    11600      +91     
- Partials     1839     1882      +43     
Flag Coverage Δ
unittests 65.76% <70.41%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/features/koordlet_features.go 100.00% <ø> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 55.49% <0.00%> (ø)
...let/qosmanager/plugins/cpusuppress/cpu_suppress.go 66.84% <54.43%> (-1.03%) ⬇️
...statesinformer/impl/states_noderesourcetopology.go 67.48% <80.76%> (-0.30%) ⬇️
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 89.65% <88.88%> (-0.97%) ⬇️
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go 88.57% <100.00%> (+0.81%) ⬆️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Sep 8, 2023
@zwzhang0107 zwzhang0107 changed the title koordlet: support be cpu share pool koordlet: report be cpu share pool and set cpuset if scheduler specified Sep 8, 2023
@zwzhang0107 zwzhang0107 changed the title koordlet: report be cpu share pool and set cpuset if scheduler specified koordlet: report be cpu share pool and set cpuset if specified Sep 8, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a3a6267 into koordinator-sh:main Sep 11, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants