New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: report be cpu share pool and set cpuset if specified #1626
koordlet: report be cpu share pool and set cpuset if specified #1626
Conversation
2850c0c
to
035c906
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 65.46% 65.76% +0.29%
==========================================
Files 371 373 +2
Lines 38654 39378 +724
==========================================
+ Hits 25306 25896 +590
- Misses 11509 11600 +91
- Partials 1839 1882 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
035c906
to
cd1cc96
Compare
cd1cc96
to
a508e54
Compare
pkg/koordlet/statesinformer/impl/states_noderesourcetopology.go
Outdated
Show resolved
Hide resolved
a508e54
to
f090b8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
f090b8a
to
9de0412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…inator-sh#1626) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
…inator-sh#1626) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Ⅰ. Describe what this PR does
Report be cpu share pool in annotation of NodeResourceTopo
Set cpuset according to specified numa node id for BE pod is scheduler specified.
BECPUSuppress should not work together with BECPUManager.
If both enabled, CPUSuppress will recover cpuset on all level for be pod does not specified numa node, and let be cpu set hook handle the others
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test