Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: report NRT zone resources mergeable #1640

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

  1. statesinformer: revise NRT reporting, mergeable update ZoneList so as to cooperate with NRT reporting of the other components.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 73.68% and project coverage change: -0.03% ⚠️

Comparison is base (a21d99f) 65.82% compared to head (20033fd) 65.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
- Coverage   65.82%   65.80%   -0.03%     
==========================================
  Files         374      375       +1     
  Lines       39484    39531      +47     
==========================================
+ Hits        25992    26013      +21     
- Misses      11609    11631      +22     
- Partials     1883     1887       +4     
Flag Coverage Δ
unittests 65.80% <73.68%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/resource.go 74.31% <68.08%> (-4.73%) ⬇️
...statesinformer/impl/states_noderesourcetopology.go 66.82% <100.00%> (-0.66%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title [WIP] koordlet: report NRT zone resources mergeable koordlet: report NRT zone resources mergeable Sep 11, 2023
@saintube saintube force-pushed the koordlet-revise-nrt-report-and-cpu-evict branch from 853951a to 489f88f Compare September 11, 2023 13:47
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-revise-nrt-report-and-cpu-evict branch from 489f88f to 20033fd Compare September 12, 2023 03:55
@koordinator-bot koordinator-bot bot added size/L and removed size/XL labels Sep 12, 2023
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 113d238 into koordinator-sh:main Sep 12, 2023
17 of 18 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants