Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: revise BECPUEvict, RdtResctrl, CPUSetAllocator and system collector #1641

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Sep 11, 2023

Ⅰ. Describe what this PR does

  1. BECPUEvict: Support evictByAllocatable policy to calculate cpu satisfaction.
  2. RdtResctrl: Support retrieve sandbox container's task IDs.
  3. CPUSetAllocator: Fix the filters for qos=LS and qos=None pods.
  4. SystemResourceCollector: Support a custom metric outdated interval.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 73.54% and project coverage change: +0.07% 🎉

Comparison is base (1560bdb) 65.76% compared to head (3d27dbe) 65.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   65.76%   65.83%   +0.07%     
==========================================
  Files         377      378       +1     
  Lines       39808    40278     +470     
==========================================
+ Hits        26181    26519     +338     
- Misses      11723    11812      +89     
- Partials     1904     1947      +43     
Flag Coverage Δ
unittests 65.83% <73.54%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/koordlet/qosmanager/qosmanager.go 44.28% <0.00%> (ø)
pkg/koordlet/util/system/resctrl_linux.go 77.17% <40.00%> (ø)
pkg/util/resource.go 66.87% <57.14%> (-7.44%) ⬇️
pkg/koordlet/util/system/resctrl.go 50.80% <57.69%> (+18.08%) ⬆️
...statesinformer/impl/states_noderesourcetopology.go 68.14% <58.33%> (+1.32%) ⬆️
pkg/koordlet/resourceexecutor/cgroup.go 62.68% <66.66%> (ø)
...et/qosmanager/plugins/resctrl/resctrl_reconcile.go 73.71% <72.30%> (-2.51%) ⬇️
.../koordlet/qosmanager/plugins/cpuevict/cpu_evict.go 72.29% <86.88%> (+3.15%) ⬆️
...ollectors/sysresource/system_resource_collector.go 67.39% <100.00%> (+0.35%) ⬆️
pkg/koordlet/metricsadvisor/framework/config.go 100.00% <100.00%> (ø)
... and 5 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the koordlet-revise-cpu-evict branch 3 times, most recently from f4b71dd to eeafe2d Compare September 12, 2023 06:50
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Sep 12, 2023
@saintube saintube force-pushed the koordlet-revise-cpu-evict branch 2 times, most recently from e6319cf to aef3021 Compare September 12, 2023 14:09
@hormes
Copy link
Member

hormes commented Sep 13, 2023

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@saintube saintube changed the title koordlet: revise cpu evict when CPUSuppress disabled koordlet: revise BECPUEvict, RdtResctrl, CPUSetAllocator and system collector Sep 13, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

…dtResctrl, CPUSetAllocator and system collector

Signed-off-by: saintube <saintube@foxmail.com>
@hormes
Copy link
Member

hormes commented Sep 14, 2023

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Sep 14, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit aabe6e6 into koordinator-sh:main Sep 14, 2023
19 checks passed
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request Jan 29, 2024
…ollector (koordinator-sh#1641)

Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…ollector (koordinator-sh#1641)

Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…ollector (koordinator-sh#1641)

Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants