Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: NodeNUMAResource only consider allocatable when generating hints #1647

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 12, 2023

Ⅰ. Describe what this PR does

The original implementation of GetPodTopologyHints of NodeNUMAResource provides special processing for CPU-binding scenarios, but this is actually problematic. For example, if a node has two NUMA Nodes, the most CPUs on each NUMA Node are allocated by CPUShare Pods. If we create a LSR Pod at this time, TopologyHint will still be generated, although the allocation will fail in the end. So we need to correct this implementation from the beginning.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.03% ⚠️

Comparison is base (0496314) 65.81% compared to head (a2a54e9) 65.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   65.81%   65.78%   -0.03%     
==========================================
  Files         377      377              
  Lines       39857    39808      -49     
==========================================
- Hits        26232    26188      -44     
+ Misses      11723    11719       -4     
+ Partials     1902     1901       -1     
Flag Coverage Δ
unittests 65.78% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/scheduler/plugins/nodenumaresource/scoring.go 84.00% <50.00%> (-1.72%) ⬇️
pkg/scheduler/plugins/nodenumaresource/plugin.go 61.71% <78.94%> (-1.09%) ⬇️
...duler/plugins/nodenumaresource/resource_manager.go 81.18% <92.00%> (+1.67%) ⬆️
...eduler/plugins/nodenumaresource/node_allocation.go 89.36% <100.00%> (ø)
...heduler/plugins/nodenumaresource/plugin_service.go 53.84% <100.00%> (ø)
...cheduler/plugins/nodenumaresource/topology_hint.go 50.74% <100.00%> (+0.74%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rating hints

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the fix_nodenumaresource_ls_lsr_mixed branch from 18c1162 to a2a54e9 Compare September 14, 2023 03:37
@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1560bdb into koordinator-sh:main Sep 14, 2023
18 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…rating hints (koordinator-sh#1647)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
…rating hints (koordinator-sh#1647)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants