New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: NodeNUMAResource only consider allocatable when generating hints #1647
koord-scheduler: NodeNUMAResource only consider allocatable when generating hints #1647
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 65.81% 65.78% -0.03%
==========================================
Files 377 377
Lines 39857 39808 -49
==========================================
- Hits 26232 26188 -44
+ Misses 11723 11719 -4
+ Partials 1902 1901 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…rating hints Signed-off-by: Joseph <joseph.t.lee@outlook.com>
18c1162
to
a2a54e9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rating hints (koordinator-sh#1647) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…rating hints (koordinator-sh#1647) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
The original implementation of GetPodTopologyHints of NodeNUMAResource provides special processing for CPU-binding scenarios, but this is actually problematic. For example, if a node has two NUMA Nodes, the most CPUs on each NUMA Node are allocated by CPUShare Pods. If we create a LSR Pod at this time, TopologyHint will still be generated, although the allocation will fail in the end. So we need to correct this implementation from the beginning.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test