Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DisableDefaultQuota featuregate #1665

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

add a feature gate to disable default quota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 45.71% and project coverage change: -0.01% ⚠️

Comparison is base (fbe725f) 65.95% compared to head (670989e) 65.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
- Coverage   65.95%   65.94%   -0.01%     
==========================================
  Files         380      380              
  Lines       40867    40930      +63     
==========================================
+ Hits        26952    26990      +38     
- Misses      11942    11958      +16     
- Partials     1973     1982       +9     
Flag Coverage Δ
unittests 65.94% <45.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/features/features.go 60.00% <ø> (ø)
pkg/features/scheduler_features.go 100.00% <ø> (ø)
pkg/scheduler/plugins/elasticquota/plugin.go 55.82% <0.00%> (-4.71%) ⬇️
pkg/webhook/elasticquota/pod_check.go 54.66% <25.00%> (-2.28%) ⬇️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 72.19% <52.17%> (-2.81%) ⬇️
pkg/scheduler/plugins/elasticquota/pod_handler.go 59.25% <70.37%> (+12.48%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Sep 19, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 00434f4 into koordinator-sh:main Sep 19, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Co-authored-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants