Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: NodeNUMAResource supports amplification ratios #1671

Merged
merged 1 commit into from Sep 21, 2023

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Sep 19, 2023

Ⅰ. Describe what this PR does

The NodeNUMAResource plugin amplifies the resource per NUMA Node of NRT(BTW: later NodeResource controller supports amplification rations, we should remove the operation.), and amplify requests and allocated of CPU Bind Pod such as LSE/LSR, but once the pod scheduled, the resource-status just records the original requests. For example, One LSR Pod requests 4000m CPU, and Node-A has amplification ratios such as { "cpu": 1.5 }, so the plugin amplified the requests to 6000m, but in the NUMA Node still allocated 4000m. This is done because the amplification ratios change dynamically.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Sep 19, 2023

/hold waiting for merge #1669

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 78.08% and project coverage change: +0.01% 🎉

Comparison is base (9e09a0b) 65.96% compared to head (7e8ea59) 65.98%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
+ Coverage   65.96%   65.98%   +0.01%     
==========================================
  Files         380      380              
  Lines       40943    41010      +67     
==========================================
+ Hits        27009    27060      +51     
- Misses      11960    11970      +10     
- Partials     1974     1980       +6     
Flag Coverage Δ
unittests 65.98% <78.08%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...heduler/plugins/nodenumaresource/plugin_service.go 70.90% <0.00%> (+17.06%) ⬆️
pkg/scheduler/plugins/nodenumaresource/util.go 81.25% <71.42%> (-7.64%) ⬇️
...duler/plugins/nodenumaresource/topology_options.go 55.71% <72.72%> (-0.59%) ⬇️
pkg/scheduler/plugins/nodenumaresource/plugin.go 65.49% <76.92%> (+0.13%) ⬆️
...eduler/plugins/nodenumaresource/node_allocation.go 90.19% <100.00%> (+0.83%) ⬆️
...duler/plugins/nodenumaresource/resource_manager.go 81.37% <100.00%> (+0.18%) ⬆️
pkg/scheduler/plugins/nodenumaresource/scoring.go 76.29% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra
Copy link
Member Author

eahydra commented Sep 20, 2023

/hold cancel

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@hormes
Copy link
Member

hormes commented Sep 21, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f3b3eb4 into koordinator-sh:main Sep 21, 2023
19 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants