New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: NodeNUMAResource supports amplification ratios #1671
Conversation
/hold waiting for merge #1669 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
+ Coverage 65.96% 65.98% +0.01%
==========================================
Files 380 380
Lines 40943 41010 +67
==========================================
+ Hits 27009 27060 +51
- Misses 11960 11970 +10
- Partials 1974 1980 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
9bc6e4d
to
4946529
Compare
/hold cancel |
4946529
to
5266d0d
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
5266d0d
to
7e8ea59
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dinator-sh#1671) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…dinator-sh#1671) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
The NodeNUMAResource plugin amplifies the resource per NUMA Node of NRT(BTW: later NodeResource controller supports amplification rations, we should remove the operation.), and amplify requests and allocated of CPU Bind Pod such as LSE/LSR, but once the pod scheduled, the resource-status just records the original requests. For example, One LSR Pod requests 4000m CPU, and Node-A has amplification ratios such as { "cpu": 1.5 }, so the plugin amplified the requests to 6000m, but in the NUMA Node still allocated 4000m. This is done because the amplification ratios change dynamically.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test