scheduler: use asynclog to reduce klog performance overhead #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
+ Coverage 65.91% 65.95% +0.03%
==========================================
Files 385 385
Lines 41639 41639
==========================================
+ Hits 27447 27461 +14
+ Misses 12155 12143 -12
+ Partials 2037 2035 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hormes
reviewed
Oct 7, 2023
eahydra
changed the title
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
koordinator-bot
bot
merged commit cf81f9c
into
koordinator-sh:main
20 of 21 checks passed
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…tor-sh#1694) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…tor-sh#1694) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
By default, klog outputs logs synchronously to stderr, which will affect performance when there are too many logs.
Therefore, we can reduce the delay caused by syscall and IO by outputting logs asynchronously, thus improving performance.
When enable
--async-log, also need to enable-logtostderrand disable-alsologtostderr. And also can set--async-log-queue-lengthto fine-tune performance.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test