Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: support multiarch image build #1697

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Oct 8, 2023

Ⅰ. Describe what this PR does

dockerfile: support mutli-arch image build.

  1. The arm64 image will be built for each component in each PR.
  2. Skip pushing images for unmerged PRs.
  3. Module the pkg sigs.k8s.io/controller-runtime/tools/setup-envtest to resolve the Golang version issues in the latest version.

Ⅱ. Does this pull request fix one issue?

fixes #1245.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the dockerfile-support-arm64 branch 3 times, most recently from 27c8ca4 to b79fed9 Compare October 8, 2023 04:00
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d04f86b) 65.93% compared to head (56184f7) 65.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   65.93%   65.91%   -0.02%     
==========================================
  Files         384      384              
  Lines       41474    41557      +83     
==========================================
+ Hits        27344    27393      +49     
- Misses      12106    12133      +27     
- Partials     2024     2031       +7     
Flag Coverage Δ
unittests 65.91% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the dockerfile-support-arm64 branch 4 times, most recently from b975556 to 671ff01 Compare October 8, 2023 04:54
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Oct 8, 2023
Signed-off-by: saintube <saintube@foxmail.com>
@saintube
Copy link
Member Author

saintube commented Oct 9, 2023

/cc @zwzhang0107 @eahydra @hormes @jasonliu747
PTAL

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a317f1e into koordinator-sh:main Oct 9, 2023
22 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] support arm64 arch image for released chart
3 participants