-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: make ReservationInfo.AddAssignedPod idempotent #1709
scheduler: make ReservationInfo.AddAssignedPod idempotent #1709
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
- Coverage 65.91% 65.90% -0.02%
==========================================
Files 384 384
Lines 41613 41628 +15
==========================================
+ Hits 27430 27434 +4
- Misses 12145 12157 +12
+ Partials 2038 2037 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
0e61d73
into
koordinator-sh:main
…r-sh#1709) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
…r-sh#1709) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
When the scheduler starts, some Pods may be updated multiple times in a short period of time, causing the ReservationInfo to add the same Pod multiple times, and ultimately cannot be reused because the reservation's allocated is greater than or equal to the reservation's allocable.
The root cause is that the forceSyncEventHandler of the frameworkext helper module requires that all EventHandlers must be idempotent.
So the PR fix the issue. Make the ReservationInfo method
AddAssignedPod
idempotent.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test