Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make ReservationInfo.AddAssignedPod idempotent #1709

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 12, 2023

Ⅰ. Describe what this PR does

When the scheduler starts, some Pods may be updated multiple times in a short period of time, causing the ReservationInfo to add the same Pod multiple times, and ultimately cannot be reused because the reservation's allocated is greater than or equal to the reservation's allocable.

The root cause is that the forceSyncEventHandler of the frameworkext helper module requires that all EventHandlers must be idempotent.

So the PR fix the issue. Make the ReservationInfo method AddAssignedPod idempotent.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (58850b4) 65.91% compared to head (216effd) 65.90%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   65.91%   65.90%   -0.02%     
==========================================
  Files         384      384              
  Lines       41613    41628      +15     
==========================================
+ Hits        27430    27434       +4     
- Misses      12145    12157      +12     
+ Partials     2038     2037       -1     
Flag Coverage Δ
unittests 65.90% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...uler/frameworkext/helper/forcesync_eventhandler.go 77.33% <0.00%> (-1.05%) ⬇️
pkg/scheduler/frameworkext/reservation_info.go 30.00% <0.00%> (-0.59%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@buptcozy
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Oct 12, 2023
@koordinator-bot koordinator-bot bot merged commit 0e61d73 into koordinator-sh:main Oct 12, 2023
20 of 21 checks passed
@eahydra eahydra deleted the make_rinfo_addassigned_pod_idempotent branch October 12, 2023 06:54
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants