manager: add GetNodeAllocatable in quota-controller #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 65.91% 65.90% -0.01%
==========================================
Files 384 385 +1
Lines 41637 41639 +2
==========================================
- Hits 27445 27444 -1
- Misses 12155 12157 +2
- Partials 2037 2038 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
shaloulcy
force-pushed
the
fix_quota_common
branch
from
b9087d1
to
e12514f
Compare
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
shaloulcy
force-pushed
the
fix_quota_common
branch
from
e12514f
to
8776a15
Compare
|
/lgtm |
hormes
approved these changes
Oct 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test