Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: report host application resource usage for calculating batc… #1733

Merged

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Nov 7, 2023

Ⅰ. Describe what this PR does

  • koordlet collecting the resource usage of host-applications by cgroup path and report in NodeMetric
  • slo-controller consider host application resource usage during calculate batch allocatable
  • cpu suppress supports BE host application

Ⅱ. Does this pull request fix one issue?

#1727

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (06eedc1) 66.02% compared to head (7f11b4d) 65.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   66.02%   65.99%   -0.04%     
==========================================
  Files         386      388       +2     
  Lines       42049    42314     +265     
==========================================
+ Hits        27764    27926     +162     
- Misses      12236    12315      +79     
- Partials     2049     2073      +24     
Flag Coverage Δ
unittests 65.99% <70.41%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sor/collectors/beresource/be_resource_collector.go 67.20% <100.00%> (ø)
...ollectors/sysresource/system_resource_collector.go 70.87% <100.00%> (+3.48%) ⬆️
pkg/koordlet/metricsadvisor/framework/context.go 75.00% <100.00%> (+4.78%) ⬆️
.../koordlet/qosmanager/plugins/cpuevict/cpu_evict.go 72.29% <100.00%> (ø)
pkg/koordlet/util/cold_page.go 100.00% <100.00%> (ø)
pkg/koordlet/util/host_application.go 100.00% <100.00%> (ø)
...oller/noderesource/plugins/batchresource/plugin.go 76.85% <100.00%> (+0.78%) ⬆️
...troller/noderesource/plugins/batchresource/util.go 85.42% <100.00%> (+0.11%) ⬆️
...koordlet/runtimehooks/protocol/host_qos_context.go 0.00% <0.00%> (-31.43%) ⬇️
...let/qosmanager/plugins/cpusuppress/cpu_suppress.go 67.57% <90.47%> (+0.61%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…h allocatable

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit f197bbc into koordinator-sh:main Nov 8, 2023
20 checks passed
@zwzhang0107 zwzhang0107 deleted the add-host-app-metric branch November 8, 2023 08:05
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants