koordlet: add page cache collector unit test and mend default cold memory config #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUPT-wxq
force-pushed
the
main
branch
3 times, most recently
from
7b4bebe
to
690ab10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
========================================
Coverage 66.08% 66.09%
========================================
Files 388 390 +2
Lines 42373 42656 +283
========================================
+ Hits 28003 28193 +190
- Misses 12296 12373 +77
- Partials 2074 2090 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.21...v24.0.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
BUPT-wxq
changed the title
saintube
reviewed
Nov 17, 2023
pkg/koordlet/metricsadvisor/collectors/coldmemoryresource/cold_page_kidled_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
saintube
reviewed
Nov 20, 2023
pkg/koordlet/metricsadvisor/collectors/coldmemoryresource/cold_page_kidled_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
zwzhang0107
reviewed
Nov 21, 2023
pkg/koordlet/metricsadvisor/collectors/pagecache/page_cache_collector_test.go
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
saintube
reviewed
Nov 28, 2023
pkg/koordlet/metricsadvisor/collectors/pagecache/page_cache_collector_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
saintube
reviewed
Nov 29, 2023
pkg/koordlet/metricsadvisor/collectors/pagecache/page_cache_collector_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
|
/lgtm |
hormes
approved these changes
Dec 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
koordinator-bot
bot
merged commit bfa9396
into
koordinator-sh:main
19 of 20 checks passed
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…mory config (koordinator-sh#1738) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: BUPT-wxq <1725712048@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test