koordlet: fix RDT cache id issue #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
Signed-off-by: bowen-intel <bowen.song@intel.com>
bowen-intel
force-pushed
the
fix-rdt-cacheid
branch
from
60924b0
to
9d48751
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
+ Coverage 67.00% 67.02% +0.02%
==========================================
Files 407 407
Lines 45505 45551 +46
==========================================
+ Hits 30489 30530 +41
- Misses 12789 12793 +4
- Partials 2227 2228 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saintube
changed the title
|
/lgtm |
zwzhang0107
reviewed
Dec 26, 2023
bowen-intel
changed the title
bowen-intel
force-pushed
the
fix-rdt-cacheid
branch
from
831cb50
to
b13c1af
Compare
bowen-intel
changed the title
Signed-off-by: bowen-intel <bowen.song@intel.com>
bowen-intel
force-pushed
the
fix-rdt-cacheid
branch
from
b13c1af
to
a5539f4
Compare
|
PTAL, thanks 😀 @zwzhang0107 |
|
/lgtm |
Signed-off-by: zwzhang <zzw261520@alibaba-inc.com>
|
/assign @FillZpp |
|
/lgtm |
hormes
approved these changes
Jan 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bowen-intel
added a commit
to kangclzjc/koordinator
that referenced
this pull request
Jan 16, 2024
Signed-off-by: bowen-intel <bowen.song@intel.com> Signed-off-by: zwzhang <zzw261520@alibaba-inc.com> Co-authored-by: zwzhang <zzw261520@alibaba-inc.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
Signed-off-by: bowen-intel <bowen.song@intel.com> Signed-off-by: zwzhang <zzw261520@alibaba-inc.com> Co-authored-by: zwzhang <zzw261520@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
ref: #1777
Temporarily fix the issue of non-contiguous cache IDs by reading the resctrl root schemata. Since it has checked resctrl mount condition, the schemata can be considered reliable. Fix some function name issue.
Ⅱ. Does this pull request fix one issue?
fixes #1777
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test