Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: revise system qos and numa aware cpuset #1793

Conversation

saintube
Copy link
Member

@saintube saintube commented Dec 26, 2023

Ⅰ. Describe what this PR does

  • koordlet: revise the cpuset runtime hook for two cases below:
    1. If a pod allocates NUMA-aware resources excluding CPU, it should follow the non-NUMA cpuset.
    2. If a SYSTEM pod allocates NUMA-aware resources including CPU, it just follows the cpuset rule of NUMA resource since the NUMA-aware system-qos-resource is undefined.

Generally, a pod use NUMA-level cpuset should be:

  1. QoS is not SYSTEM.
  2. Pod annotations["scheduling.koordinator.sh/resource-status"].numaNodeResources[*]["cpu"] should be non-zero.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47f6715) 66.41% compared to head (7b15fba) 66.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   66.41%   66.39%   -0.03%     
==========================================
  Files         396      396              
  Lines       43730    43739       +9     
==========================================
- Hits        29045    29042       -3     
- Misses      12524    12539      +15     
+ Partials     2161     2158       -3     
Flag Coverage Δ
unittests 66.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-revise-system-qos-cpuset-with-numa-resource branch from fa5af6e to 7b15fba Compare December 26, 2023 06:59
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 265ff9e into koordinator-sh:main Dec 26, 2023
19 of 20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants