Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix be cpuset for numaResource #1818

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Jan 8, 2024

Ⅰ. Describe what this PR does

koordlet: fix sharepool cpuset when the numaResource is allocated by a BE pod.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dbdba3a) 66.90% compared to head (8b39a87) 66.88%.

Files Patch % Lines
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
- Coverage   66.90%   66.88%   -0.03%     
==========================================
  Files         404      404              
  Lines       45311    45313       +2     
==========================================
- Hits        30317    30309       -8     
- Misses      12781    12789       +8     
- Partials     2213     2215       +2     
Flag Coverage Δ
unittests 66.88% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d94be25 into koordinator-sh:main Jan 8, 2024
19 of 20 checks passed
bowen-intel pushed a commit to kangclzjc/koordinator that referenced this pull request Jan 16, 2024
Signed-off-by: saintube <saintube@foxmail.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants