Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix typo in function isBECPUUsageHighEnough #1830

Merged

Conversation

j4ckstraw
Copy link
Contributor

@j4ckstraw j4ckstraw commented Jan 12, 2024

Ⅰ. Describe what this PR does

fix #1825

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85b8130) 66.07% compared to head (c57328b) 67.01%.
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   66.07%   67.01%   +0.94%     
==========================================
  Files         389      407      +18     
  Lines       42505    45554    +3049     
==========================================
+ Hits        28084    30528    +2444     
- Misses      12342    12801     +459     
- Partials     2079     2225     +146     
Flag Coverage Δ
unittests 67.01% <100.00%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j4ckstraw
Copy link
Contributor Author

shall we add a test for isBECPUUsageHighEnough? or calculateMilliRelease?

@jasonliu747
Copy link
Member

shall we add a test for isBECPUUsageHighEnough? or calculateMilliRelease?

that would be great!

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Jan 12, 2024
@zwzhang0107 zwzhang0107 changed the title fix typo in function isBECPUUsageHighEnough koordlet: fix typo in function isBECPUUsageHighEnough Jan 12, 2024
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit acb6926 into koordinator-sh:main Jan 12, 2024
20 checks passed
bowen-intel pushed a commit to kangclzjc/koordinator that referenced this pull request Jan 16, 2024
@j4ckstraw j4ckstraw deleted the fix-isBECPUUsageHighEnough branch January 29, 2024 06:30
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] question about isBECPUUsageHighEnough
3 participants