New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix typo in function isBECPUUsageHighEnough #1830
koordlet: fix typo in function isBECPUUsageHighEnough #1830
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
+ Coverage 66.07% 67.01% +0.94%
==========================================
Files 389 407 +18
Lines 42505 45554 +3049
==========================================
+ Hits 28084 30528 +2444
- Misses 12342 12801 +459
- Partials 2079 2225 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shall we add a test for isBECPUUsageHighEnough? or calculateMilliRelease? |
that would be great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
0d7931c
to
c57328b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1830) Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
…#1830) Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Ⅰ. Describe what this PR does
fix #1825
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test