koordlet: add taskids in statesinformer #2057
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kangclzjc
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 68.56% 68.55% -0.02%
==========================================
Files 430 430
Lines 39383 39912 +529
==========================================
+ Hits 27004 27362 +358
- Misses 10043 10184 +141
- Partials 2336 2366 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@saintube PTAL. |
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
kangclzjc
force-pushed
the
dev_add_taskids
branch
from
2ef1f0b
to
0107ae9
Compare
|
@saintube PTAL. |
| @@ -159,6 +227,11 @@ func (s *podsInformer) syncPods() error { | |||
| CgroupDir: genPodCgroupParentDir(pod), | |||
| } | |||
| newPodMap[string(pod.UID)] = podMeta | |||
| if s.config.EnablePodTaskIds && pod.Status.Phase != corev1.PodSucceeded && pod.Status.Phase != corev1.PodFailed { | |||
There was a problem hiding this comment.
recommend to use util.IsPodTerminated
Ⅰ. Describe what this PR does
Add taskids for each pod as an attributes. It's part of the #1974. Resctrl runtime hook will leverage this to write new taskids to resctrl group.
Ⅱ. Does this pull request fix one issue?
#1831
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test