Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace reinvented wheel with Get() in standard library #244

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

image

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #244 (63d8cf8) into main (5d624d7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   58.40%   58.37%   -0.04%     
==========================================
  Files         103      103              
  Lines        9582     9575       -7     
==========================================
- Hits         5596     5589       -7     
  Misses       3521     3521              
  Partials      465      465              
Flag Coverage Δ
unittests 58.37% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/audit/auditor.go 71.42% <100.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d624d7...63d8cf8. Read the comment docs.

@jasonliu747 jasonliu747 force-pushed the refine branch 2 times, most recently from cd75bcc to 2512651 Compare June 14, 2022 02:26
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@eahydra
Copy link
Member

eahydra commented Jun 14, 2022

/lgtm

@hormes
Copy link
Member

hormes commented Jun 14, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d139458 into koordinator-sh:main Jun 14, 2022
@jasonliu747 jasonliu747 added this to the v0.5 milestone Jun 14, 2022
@jasonliu747 jasonliu747 deleted the refine branch June 14, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants