Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable CGO when GoReleaser compiles binaries #334

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

This PR would enable CGO when GoReleaser is compiling binaries.

Ⅱ. Does this pull request fix one issue?

image

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #334 (f6b2622) into main (37a3aec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files         116      116           
  Lines       11438    11438           
=======================================
  Hits         7425     7425           
  Misses       3426     3426           
  Partials      587      587           
Flag Coverage Δ
unittests 64.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a3aec...f6b2622. Read the comment docs.

@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 1, 2022
@hormes
Copy link
Member

hormes commented Jul 4, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f89c582 into koordinator-sh:main Jul 4, 2022
@jasonliu747 jasonliu747 deleted the cgo branch July 5, 2022 06:33
jasonliu747 added a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants