-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve koordlet log verbosity #338
Conversation
0acd1c5
to
d1d7e57
Compare
Signed-off-by: saintube <saintube@foxmail.com>
d1d7e57
to
8d0a149
Compare
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 64.89% 64.85% -0.04%
==========================================
Files 116 116
Lines 11438 11448 +10
==========================================
+ Hits 7423 7425 +2
- Misses 3428 3438 +10
+ Partials 587 585 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
improve the log verbosity of koordlet.
For example, when we use Centos 7, we don't expect an error-like log for the cgroup file
cpu.burst_us
, since this file may not exist on OSs other than Anolis OS.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
reduce misunderstandings when koordlet is deployed with the default log level
Ⅳ. Special notes for reviews
some refactoring may conflict with #328
V. Checklist
make test