Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve koordlet log verbosity #338

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

saintube
Copy link
Member

@saintube saintube commented Jul 4, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

improve the log verbosity of koordlet.

For example, when we use Centos 7, we don't expect an error-like log for the cgroup file cpu.burst_us, since this file may not exist on OSs other than Anolis OS.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

reduce misunderstandings when koordlet is deployed with the default log level

Ⅳ. Special notes for reviews

some refactoring may conflict with #328

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #338 (8d0a149) into main (f89c582) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   64.89%   64.85%   -0.04%     
==========================================
  Files         116      116              
  Lines       11438    11448      +10     
==========================================
+ Hits         7423     7425       +2     
- Misses       3428     3438      +10     
+ Partials      587      585       -2     
Flag Coverage Δ
unittests 64.85% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 9.69% <0.00%> (ø)
pkg/koordlet/resmanager/cpu_burst.go 76.06% <42.85%> (-1.47%) ⬇️
pkg/koordlet/resmanager/memory_evict.go 72.07% <75.00%> (ø)
pkg/koordlet/reporter/reporter.go 38.05% <100.00%> (ø)
pkg/koordlet/resmanager/cgroup_reconcile.go 86.19% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89c582...8d0a149. Read the comment docs.

@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 4, 2022
@hormes
Copy link
Member

hormes commented Jul 5, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes merged commit 6ac04d4 into koordinator-sh:main Jul 5, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants