Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor extended resource with kubernetes.io namespace #350

Merged
merged 1 commit into from
Aug 8, 2022
Merged

refactor extended resource with kubernetes.io namespace #350

merged 1 commit into from
Aug 8, 2022

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jul 7, 2022

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#83

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 changed the title extended resource refactor refactor extended resource with kubernetes.io namespace Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #350 (842572a) into main (54ed9a5) will increase coverage by 1.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   64.85%   66.26%   +1.41%     
==========================================
  Files         116      116              
  Lines       11451    11580     +129     
==========================================
+ Hits         7426     7674     +248     
+ Misses       3440     3317     -123     
- Partials      585      589       +4     
Flag Coverage Δ
unittests 66.26% <ø> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/handler.go 38.03% <0.00%> (-0.67%) ⬇️
...heduler/plugins/nodenumaresource/node_numa_info.go 59.64% <0.00%> (-0.60%) ⬇️
pkg/koordlet/metricsadvisor/collector.go 9.78% <0.00%> (+0.08%) ⬆️
...cheduler/plugins/nodenumaresource/cpu_allocator.go 83.63% <0.00%> (+0.68%) ⬆️
pkg/scheduler/plugins/nodenumaresource/plugin.go 70.93% <0.00%> (+1.98%) ⬆️
...scheduler/plugins/nodenumaresource/cpu_topology.go 33.03% <0.00%> (+2.67%) ⬆️
pkg/runtimeproxy/server/docker/utils.go 86.00% <0.00%> (+2.93%) ⬆️
pkg/runtimeproxy/resexecutor/cri/pod.go 46.80% <0.00%> (+23.40%) ⬆️
pkg/runtimeproxy/resexecutor/cri/utils.go 87.62% <0.00%> (+26.20%) ⬆️
pkg/koordlet/audit/config.go 100.00% <0.00%> (+26.66%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zwzhang0107 zwzhang0107 changed the title refactor extended resource with kubernetes.io namespace refactor extended resource with koordinator.kubernetes.io namespace Jul 7, 2022
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@zwzhang0107 zwzhang0107 changed the title refactor extended resource with koordinator.kubernetes.io namespace refactor extended resource with kubernetes.io namespace Jul 28, 2022
@hormes
Copy link
Member

hormes commented Aug 8, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0829305 into koordinator-sh:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants