Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support default preferredCPUBindPolicy for LSE/LSR P… #354

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jul 8, 2022

…od if not specified

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes July 8, 2022 14:47
@eahydra eahydra added this to the v0.6 milestone Jul 8, 2022
@eahydra eahydra requested review from saintube and removed request for FillZpp July 8, 2022 14:47
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #354 (7ef336c) into main (171ad3e) will increase coverage by 0.02%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   64.85%   64.87%   +0.02%     
==========================================
  Files         116      116              
  Lines       11451    11467      +16     
==========================================
+ Hits         7426     7439      +13     
- Misses       3440     3442       +2     
- Partials      585      586       +1     
Flag Coverage Δ
unittests 64.87% <86.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 69.62% <86.36%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171ad3e...7ef336c. Read the comment docs.

@eahydra eahydra requested a review from saintube July 11, 2022 02:59
…od if not specified

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_default_cpu_bind_policy branch from 7bb770f to 7ef336c Compare July 11, 2022 03:40
@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Jul 11, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1ab5c99 into koordinator-sh:main Jul 11, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
…od if not specified (koordinator-sh#354)

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants