Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node cpu orchestration api #360

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Support node cpu orchestration api #360

merged 1 commit into from
Jul 14, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jul 11, 2022 •
edited
Loading

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes July 11, 2022 13:13
@eahydra
Copy link
Member Author

eahydra commented Jul 11, 2022

/hold

@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #360 (8eacc7c) into main (42d695f) will increase coverage by 0.06%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   66.20%   66.26%   +0.06%     
==========================================
  Files         116      116              
  Lines       11554    11580      +26     
==========================================
+ Hits         7649     7674      +25     
+ Misses       3319     3317       -2     
- Partials      586      589       +3
Flag Coverage Δ
unittests 66.26% <71.87%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 70.93% <70.96%> (+1.20%) ⬆️
...cheduler/plugins/nodenumaresource/cpu_allocator.go 83.63% <100.00%> (ø)
...scheduler/plugins/nodenumaresource/cpu_topology.go 33.03% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d695f...8eacc7c. Read the comment docs.

@eahydra eahydra force-pushed the support_node_cpu_orchestration_api branch from 889e327 to f969947 Compare July 12, 2022 12:01
@koordinator-bot koordinator-bot bot added size/M and removed size/XL labels Jul 12, 2022
@eahydra eahydra marked this pull request as ready for review July 12, 2022 12:01
@eahydra eahydra requested review from saintube and removed request for FillZpp July 12, 2022 12:02
@eahydra
Copy link
Member Author

eahydra commented Jul 12, 2022

append UT later..

@eahydra eahydra force-pushed the support_node_cpu_orchestration_api branch from f969947 to a72b75e Compare July 12, 2022 12:04
@eahydra eahydra force-pushed the support_node_cpu_orchestration_api branch from a72b75e to 45ab526 Compare July 14, 2022 06:11
@eahydra
koord-scheduler: support Node CPU orchestration API
8eacc7c 
- support cpu bind policy with FullPCPUsOnly
- support NUMA allocate strategy with MostAllocated/LeastAllocated

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_node_cpu_orchestration_api branch from 45ab526 to 8eacc7c Compare July 14, 2022 08:49
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Jul 14, 2022
@eahydra
Copy link
Member Author

eahydra commented Jul 14, 2022

/hold cancel

jasonliu747
jasonliu747 reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 14, 2022
@eahydra eahydra requested a review from hormes July 14, 2022 09:06
@hormes
Copy link
Member

hormes commented Jul 14, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8179245 into koordinator-sh:main Jul 14, 2022
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 19, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
@eahydra @jasonliu747
koord-scheduler: support Node CPU orchestration API (koordinator-sh#360)
50cafbe 
- support cpu bind policy with FullPCPUsOnly
- support NUMA allocate strategy with MostAllocated/LeastAllocated

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonliu747 jasonliu747 jasonliu747 left review comments

@saintube saintube Awaiting requested review from saintube

@hormes hormes Awaiting requested review from hormes

Assignees

@jasonliu747 jasonliu747

Labels
approved lgtm size/L
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eahydra @hormes @jasonliu747