-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[koord-runtime-proxy] fix the loss of new updated resources from UpdateContainerResources request #363
[koord-runtime-proxy] fix the loss of new updated resources from UpdateContainerResources request #363
Conversation
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 65.36% 66.12% +0.75%
==========================================
Files 116 116
Lines 11495 11557 +62
==========================================
+ Hits 7514 7642 +128
+ Misses 3394 3329 -65
+ Partials 587 586 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0455afc
to
4a9af9f
Compare
/lgtm |
…equest Signed-off-by: Cheimu <xerhoneyfc@gmail.com> fix the loss of new updated resources from UpdateContainerResources request
fdeb03e
to
788a908
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…equest (koordinator-sh#363) Signed-off-by: Cheimu <xerhoneyfc@gmail.com> fix the loss of new updated resources from UpdateContainerResources request
Signed-off-by: Cheimu xerhoneyfc@gmail.com
Ⅰ. Describe what this PR does
Requests
try to update container's resources by resources fields within the request. However current implementation directly drop the resources fields, which will block any update operation. This pr fix this problem.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test