Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[koord-runtime-proxy] fix the loss of new updated resources from UpdateContainerResources request #363

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

cheimu
Copy link
Member

@cheimu cheimu commented Jul 12, 2022

Signed-off-by: Cheimu xerhoneyfc@gmail.com

Ⅰ. Describe what this PR does

Requests

  • UpdateContainer - docker
  • UpdateContainerResources - containerd

try to update container's resources by resources fields within the request. However current implementation directly drop the resources fields, which will block any update operation. This pr fix this problem.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #363 (fdeb03e) into main (05a8c11) will increase coverage by 0.75%.
The diff coverage is 89.06%.

❗ Current head fdeb03e differs from pull request most recent head 788a908. Consider uploading reports for the commit 788a908 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   65.36%   66.12%   +0.75%     
==========================================
  Files         116      116              
  Lines       11495    11557      +62     
==========================================
+ Hits         7514     7642     +128     
+ Misses       3394     3329      -65     
+ Partials      587      586       -1     
Flag Coverage Δ
unittests 66.12% <89.06%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/handler.go 38.03% <0.00%> (-0.67%) ⬇️
pkg/runtimeproxy/resexecutor/cri/container.go 60.46% <50.00%> (+28.20%) ⬆️
pkg/runtimeproxy/resexecutor/cri/utils.go 87.62% <100.00%> (+26.20%) ⬆️
pkg/runtimeproxy/server/docker/utils.go 86.00% <100.00%> (+2.93%) ⬆️
pkg/runtimeproxy/resexecutor/cri/pod.go 46.80% <0.00%> (+23.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a8c11...788a908. Read the comment docs.

@cheimu cheimu force-pushed the fix/update-resource branch 2 times, most recently from 0455afc to 4a9af9f Compare July 12, 2022 12:38
@ZYecho
Copy link
Contributor

ZYecho commented Jul 12, 2022

/lgtm

…equest

Signed-off-by: Cheimu <xerhoneyfc@gmail.com>

fix the loss of new updated resources from UpdateContainerResources request
@ZYecho
Copy link
Contributor

ZYecho commented Jul 12, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 12, 2022
@hormes
Copy link
Member

hormes commented Jul 13, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b2fcc22 into koordinator-sh:main Jul 13, 2022
@cheimu cheimu deleted the fix/update-resource branch July 13, 2022 02:53
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 19, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
…equest (koordinator-sh#363)

Signed-off-by: Cheimu <xerhoneyfc@gmail.com>

fix the loss of new updated resources from UpdateContainerResources request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants